Tuesday, September 16, 2008

further adventures in offshoring

Have not had time to do a code review for the project I've inherited. Decided to use FindBugs to pick off low hanging fruit.

aiiiiiiiieeeee.
  • bitwise '&' operator used instead of boolean '&&' operator
  • '==' operator used for Long/Integer/many-other-reference-types
  • String.equals() comparing a String to a DO object
  • Enum classes with their own extra-special equals() methods. Ick.
  • Classes with equals() but no hashCode()
  • Who implements finalize()?
  • many, many more

2 comments:

Bartski said...

I pity the fool what doesn't put MR T in every post.


There, I got mine in this time. Ha!

UberJeff said...

Due to the extremely high quality of the other software products you are dealing with, I find your comments hard to believe. Shame on you for even considering performing a code review.